aiannacc / Goko-Salvager

Enhance your Dominion Online experience!
13 stars 9 forks source link

Kingdom Generator defaults #158

Closed allanjackson closed 10 years ago

allanjackson commented 10 years ago

It would be nice if the Kingdom Generator would basically assume the user put ", all" at the end of every kingdom.

This way you could just type something like "kings court" and it would be interpreted as "kings court, all".

This enhancement would provide an intelligent default value that would prevent a common user error when entering a kingdom.

aiannacc commented 10 years ago

Nutki's original documentation says "On top of that, if you specify less than 11 sets, the last set will be used for the missing ones." This is the current implementation.

To me, this makes more sense, as a user who enters "Seaside" wants a kingdom with all Seaside cards, not 1 Seaside card and the rest chosen randomly.

Perhaps the better solution would be to give a more informative error message. So if you enter "King's Court" instead of "King's Court, All" you get a dialog like this:

"The kingdom generator repeats the last entry to fill out the unspecified cards. So you just asked it for a kingdom with 10 King's Courts. Did you actually want King's Court plus nine random cards? |Yes, of course I did!| |No, let me reenter| Use "King's Court, All" to avoid this message in the future."

allanjackson commented 10 years ago

I agree, if someone puts in "seaside" it should do 10 seaside cards, not "seaside, all", so my original suggestion won't quite work.

I don't know much about how the generation code works, but would it be possible to implement it such that if less than 10 cards were selected from the user's input, then add the ", all"?

That way both "seaside" and "king's court" would work as the user expects.

aiannacc commented 10 years ago

Yeah, that might be best. And I think it'd be pretty easy to implement:

  1. Try generating with the given input
  2. If failed, try generating with ", All" added to the input