Salvager not loading in Safari

[jl8e]

Salvager 2.4.1

It doesn’t load at all.

Having poked around a bit, I this is probably because it’s still referring to goko.com in src/config/safari/Info.plist.erb

[aiannacc]

Thanks. I modified that entry. Should work now, but I haven't tested it. Please reopen this if it's still busted. 030b2e22b2ffa9b94febd267352a4f8539c98fbf

[jl8e]

The linked downloadable version hasn’t been updated.

I got a Safari dev certificate and built it myself, and it’s still not activating, despite the allowed domains being *.playdominion.com, and the whitelist including www.playdominion.com/Dominion/gameClient.html in both http and https flavors. (No error messages in the console.)

[aiannacc]

Hoo boy... yeah, the github page was wildly out of date. Probably the f.ds links are inaccurate too. I just fixed the github links at least.

v2.4.3 works on playdominion.com for me. I'm using Safari 5.1.7 for Windows. You're using v2.4.3 and getting nothing in the Java Console?

Incidentally, I just discovered that "automatic" updating in Safari has to be specially enabled on the Extensions settings page. Once it is, the Safari version should look to https://www.gokosalvager.com:8888/update_safari.plist for updates.

[jl8e]

Still not working. (I was really hoping I’d screwed up the build somehow.)

Safari 7.0.2 on Mavericks.

Looks like I’m going to have to start digging.

[jl8e]

It’s now loading, after a restart of Safari. (Since I think I did that before, I’ll note that this restart was done with no version of the extension installed. I then installed it, and it works.)

Looks like a safari bug rather than an extension bug.

[aiannacc]

I found the Safari developer stuff to be really finicky and ill-documented. Glad you got it working at least.