search

aiannacc / Goko-Salvager

Enhance your Dominion Online experience!
13 stars 9 forks source link

QuickGame can't be modified #224

Open aiannacc opened 10 years ago

aiannacc commented 10 years ago

If I create a game with "Quick Game" and then try to modify it, I experience two bugs:

  1. The game settings window is not centered. It's far enough down and to the right that the Update button itself is off the screen. I only experience this on Chromium with archlinux, not on Chrome with Win7 or OSX 10.9.2.
  2. The Update button doesn't work. After I change the title or whatever, I click Update but the dialog does not close. Nothing is output in the JS log.
yed commented 10 years ago

It works if you create your a game witch "Create Game" button first. Probably the create game dialog is not properly initialized.

I also have following error in log:

Uncaught SyntaxError: Unexpected token u FS.CardBuilder.js:2966
ImageLib.getCardData FS.CardBuilder.js:2966
(anonymous function) FS.DeckBuilder.js:3359
b.each.b.forEach underscore-min.js:11
FS.Dominion.DeckBuilder.Model.CardDeck.Backbone.Model.extend.resetFromKingdomCards FS.DeckBuilder.js:3358
Package.DominionEditTableView.Package.EditTableView.extend._renderSettingCardsWrapper FS.MeetingRoom.Dominion.js:12895
Package.DominionEditTableView.Package.EditTableView.extend.modifyDOM FS.MeetingRoom.Dominion.js:12864
object.(anonymous function) utils.js:33
Package.EditTableView.Package.MeetingRoomBaseView.extend.resetData FS.MeetingRoom.Dominion.js:9155
Package.EditTableView.Package.MeetingRoomBaseView.extend.show FS.MeetingRoom.Dominion.js:9177
lazyShow FS.MeetingRoom.Dominion.js:13192
Package.DominionEditTableView.Package.EditTableView.extend.show FS.MeetingRoom.Dominion.js:13207
Package.ClassicTableView.Package.MeetingRoomBaseView.extend.onClickConfig FS.MeetingRoom.Dominion.js:8646
jQuery.event.dispatch jquery-1.7.1.js:3256
$event.dispatch FS.DeckBuilder.Lib.js:969
elemData.handle.eventHandle jquery-1.7.1.js:2875

full log:

event.returnValue is deprecated. Please use the standard event.preventDefault() instead. jquery-1.7.1.js:3445
gatherUrlCookieParams found the following URL params: [""] FSSDK.js:553
ConnectionMaker merged the following cookie params: ["", cookieid: null] FSSDK.js:563
FS.MessageWebSocketConnection.prototype.connect: currently trying - wss://wss.prod.dominion.makingfun.com:443 FSSDK.js:13424
Starting Goko Salvager 2.5.4.3 init.js:5
Loading Utils utils.js:4
Loading Settings Dialog blacklistSync.js:3
Loading Settings Dialog settingsDialog.js:3
Loading Notifications Module notifications.js:4
Loading autokick speedTweak.js:4
Loading Always Stack alwaysStack.js:4
Loading LaunchScreenLoader launchScreenLoader.js:3
Loading Module Loader module_loader.js:4
Preparing to load module WS Connection module_loader.js:40
FSSDK: webSocket: onopen: top: url:wss://wss.prod.dominion.makingfun.com:443 FSSDK.js:13479
Setting up GA connection heartbeat every: 60000 milliseconds FSSDK.js:13522
initMeetingRoom DominionClient.js:304
This element isn't a canvas - TypeError: undefined is not a function FSSDK.Notifier.js:198
This is a HTML Element FSSDK.Notifier.js:102
Dimension: W0px H0px @L477px T0px FSSDK.Notifier.js:115
Loading module WS Connection module_loader.js:55
Loading WS Connection module connection.js:25
Creating WebSocket connection to gokosalvager.com utils.js:8
Preparing to load module Avatars module_loader.js:40
Loading module Avatars module_loader.js:44
Preparing to load module Avatar Upload module_loader.js:40
Loading module Avatar Upload module_loader.js:44
Preparing to load module Blacklist module_loader.js:40
Loading module Blacklist module_loader.js:44
Preparing to load module Blacklist Sync module_loader.js:40
Loading module Blacklist Sync module_loader.js:44
Attr.specified is deprecated. Its value is always true. angular.min.js:40
Preparing to load module User Settings Dialog module_loader.js:40
Loading module User Settings Dialog module_loader.js:44
Preparing to load module Launch Screen Loader module_loader.js:40
Loading module Launch Screen Loader module_loader.js:44
Preparing to load module Notifications module_loader.js:40
Loading module Notifications module_loader.js:44
Preparing to load module Lobby Ratings module_loader.js:40
Loading module Lobby Ratings module_loader.js:44
Preparing to load module Deck Tracker module_loader.js:40
Loading module Deck Tracker module_loader.js:44
Preparing to load module Table State module_loader.js:40
Loading module Table State module_loader.js:44
Preparing to load module autokick module_loader.js:40
Loading module autokick module_loader.js:44
Preparing to load module Kingdom Generator module_loader.js:40
Loading module Kingdom Generator module_loader.js:44
Preparing to load module speedTweak module_loader.js:40
Loading module speedTweak module_loader.js:44
Tweaking animation speeds. speedTweak.js:17
Preparing to load module Always Stack module_loader.js:40
Loading module Always Stack module_loader.js:44
Preparing to load module Automatch Game Popup module_loader.js:40
Loading module Automatch Game Popup module_loader.js:44
Preparing to load module Automatch Offer Popup module_loader.js:40
Loading module Automatch Offer Popup module_loader.js:44
Preparing to load module Automatch Seek Popup module_loader.js:40
Loading module Automatch Seek Popup module_loader.js:44
Preparing to load module Automatch module_loader.js:40
Loading module Automatch module_loader.js:44
Preparing to load module QuickGame module_loader.js:40
Loading module QuickGame module_loader.js:44
Preparing to load module Sidebar module_loader.js:40
Loading module Sidebar module_loader.js:44
Preparing to load module Prettified Log Viewer module_loader.js:40
Loading module Prettified Log Viewer module_loader.js:44
Preparing to load module VP Calculator module_loader.js:40
Loading module VP Calculator module_loader.js:44
Preparing to load module VP Toggle module_loader.js:40
Loading module VP Toggle module_loader.js:44
Preparing to load module VP Counter module_loader.js:40
Loading module VP Counter module_loader.js:44
Preparing to load module Chat Box module_loader.js:40
Loading module Chat Box module_loader.js:44
Preparing to load module autozap module_loader.js:40
Loading module autozap module_loader.js:44
Successfully subscribed to player notifications FSSDK.js:20398
Player Info Fetched  
Object {status: (...), name: (...), id: (...), authorizationAgents: (...), creationDate: (...)…}
 DominionClient.js:847
Connected to gokosalvager.com connection.js:46
TODO: Update icon for status: 1 connection.js:165
Uncaught Invalid server message type: ADD_EXTUSER connection.js:98
GS.WS.conn.onmessage connection.js:98
Launch screen not ready after 5s launchScreenLoader.js:74
Launch Screen ready. launchScreenLoader.js:66
Create achievements response:  
Object {message: "Status", source: "Object", tag: "-FSMsgWSTag44", sqA: 43, data: Object…}
 DominionClient.js:753
Loaded avatar cache from gokosalvager.com avatars.js:20
Retrieved and cached common blacklist blacklist.js:33
Quick game script loaded. utils.js:8
Initializing quick game. utils.js:8
Initializing quick game button utils.js:8
Not already loaded Automatch automatch.js:929
Automatch script loaded. utils.js:8
Initializing Automatch utils.js:8
Goko.Player.preloader() utils.js:8
ISO level cache not yet available. Queing request to be resolved later lobby_ratings.js:212
Uncaught Invalid server message type: REM_EXTUSER connection.js:98
Uncaught Invalid server message type: ADD_EXTUSER connection.js:98
Goko.Player.preloader() utils.js:8
Uncaught Invalid server message type: ADD_EXTUSER connection.js:98
Uncaught SyntaxError: Unexpected token u FS.CardBuilder.js:2966
ImageLib.getCardData FS.CardBuilder.js:2966
(anonymous function) FS.DeckBuilder.js:3359
b.each.b.forEach underscore-min.js:11
FS.Dominion.DeckBuilder.Model.CardDeck.Backbone.Model.extend.resetFromKingdomCards FS.DeckBuilder.js:3358
Package.DominionEditTableView.Package.EditTableView.extend._renderSettingCardsWrapper FS.MeetingRoom.Dominion.js:12895
Package.DominionEditTableView.Package.EditTableView.extend.modifyDOM FS.MeetingRoom.Dominion.js:12864
object.(anonymous function) utils.js:33
Package.EditTableView.Package.MeetingRoomBaseView.extend.resetData FS.MeetingRoom.Dominion.js:9155
Package.EditTableView.Package.MeetingRoomBaseView.extend.show FS.MeetingRoom.Dominion.js:9177
lazyShow FS.MeetingRoom.Dominion.js:13192
Package.DominionEditTableView.Package.EditTableView.extend.show FS.MeetingRoom.Dominion.js:13207
Package.ClassicTableView.Package.MeetingRoomBaseView.extend.onClickConfig FS.MeetingRoom.Dominion.js:8646
jQuery.event.dispatch jquery-1.7.1.js:3256
$event.dispatch FS.DeckBuilder.Lib.js:969
elemData.handle.eventHandle jquery-1.7.1.js:2875
Uncaught Invalid server message type: REM_EXTUSER connection.js:98
2
Uncaught Invalid server message type: ADD_EXTUSER connection.js:98
Uncaught Invalid server message type: REM_EXTUSER connection.js:98
Uncaught Invalid server message type: ADD_EXTUSER connection.js:98
Uncaught Invalid server message type: REM_EXTUSER connection.js:98
serakfalcon commented 10 years ago

I experienced a problem with this also. Quick Game expects cards to be already cached, but never runs the code that would cache the cards in the first place. If you run the Create Game first, it'll cache the cards, I think that's why it works.