Closed theblankman closed 10 years ago
yed
commented
10 years ago It is probably the same with Create Game.
Do you own any sets? If only base then why create a game? That game is base only, so others can join and you will have base only game even without automatch.
theblankman
commented
10 years ago I own all the expansions, so that's another weird thing, shouldn't Automatch have made me the host since I own more sets? Here's the game if that helps: http://gokosalvager.com/static/logprettifier.html?20140514/log.51600542e4b059d9adc7afea.1400077914183.txt
aiannacc
commented
10 years ago Putting everything the automatch dialog can do into the game title isn't a great solution. Some titles are getting truncated by the Goko UI already, and there's no point in putting info there that only applies to automatch and not to people who join your game manually.
We could add the missing automatch features to the existing Create Game dialog (like the "Use Automatch" button), or we could consolidate the dialogs into a single one that handles both functions. If we implement the latter solution, we could also fix some of the long-standing issues with the Create Game dialog, like the long delay when generating the first kingdom after login, the fact that the kingdom generator pops up in a modal dialog, etc.
The base-only issue is an outstanding automatch bug. I described it in the Salvager thread a while back, but I'd never made an issue for it here. It's #231.
theblankman
commented
10 years ago Yeah, I didn't mean to suggest putting everything in the title, I meant that the missing options could be added to the Quick Game section of User Settings as well as the Create Game dialog. But that puts the same stuff in three places, so I think your idea of having one place for Automatch settings is cleaner. Maybe make it a tab under User Settings? Then let Create Game, Quick Game and the Automatch lobby button all use settings from there. Create Game and Quick Game could also add requirements from the game title if needed.
I'm not sure about combining Create Game and Automatch settings into one dialog. If that's the single place for Automatch settings, having Quick Game and the Automatch button also use those settings isn't very intuitive. And the Automatch stuff plus the kingdom-building stuff might be too much for one dialog.
theblankman
commented
10 years ago If no one else is working this, I'm going to take a stab at making a single place for Automatch settings (probably a new tab under User Settings), and having all three sources of Automatch requests: Create Game, Quick Game and the Automatch button, use those settings. Create Game and Quick Game would start with those requirements and tack on additional ones parsed from the game title.
This would also give a workaround for #231. An Automatch Request from Quick Game will be able to have a number-of-sets requirement. Then if the server thinks the user owns no expansions, as happens in #231 when the user's sets owned info isn't populated, it would have to automatch the user with someone else who does own expansions. So for that request, the user would have fewer possible opponents, but wouldn't get an undesired game. It's not the perfect fix for #231 but it's an improvement.
aiannacc
commented
10 years ago Fixed by #238
When using Quick Game with "Use Automatch" turned on, the automatch request contains only the reqs from the Quick Game title, not the reqs I would see if I clicked the Automatch button manually. As a result, there is no way to make Quick Game request an automatch with requirements on what sets the opponent has. I just got automatched into a base-only game that way. Log of the automatch and game:
After this occurred, I submitted an automatch request using the automatch button, here's the rest of the log:
The second automatch request has NumSets and RelativeRating rules, and there doesn't seem to be a way to specify those rules when using Automatch with Quick Game (this might also be true with Create Game, I haven't checked). Not sure if it's a bug or intended that Quick Game with Automatch doesn't use saved Automatch settings. If it's intended, then Quick Game options need to include all the requirements in the regular Automatch UI.