aiannacc / Goko-Salvager

Enhance your Dominion Online experience!
13 stars 9 forks source link

Automatch request submitted without setsOwned info #231

Open aiannacc opened 10 years ago

aiannacc commented 10 years ago

Some players who own all expansions have reported getting a base-only game through automatch. This is how that can happen:

Quoting myself in the Salvager thread:

Salvager asks MF/Goko which sets you own, and it isn't supposed to allow you to submit an automatch request until it gets an answer, but "Use Automatch" and "Quick Game" both unintentionally evade the code I originally wrote to enforce that requirement.

So my server receives an automatch request claiming that you own no expansions, not even Base. Instead of freaking out at this impossible request, it just has your opponent host. If your automatch settings allow a Base-only match (the default), it's possible to match with an opponent who has only Base.

To clarify, I originally wrote the automatch code to wait until the user's Goko ratings and sets owned had been retrieved from the Goko server before the automatch button become clickable.

Auto-automatch evades this because it just submits the request directly without clicking anything. But it usually isn't a problem because the Create Game dialog is so slow anyway and there's plenty of time to retrieve the player's sets owned. So the bug never got reported back then.

But the QuickGame is too efficient. :) It allows the user to submit an automatch request as soon as the lobby loads, which sometimes means that the user's sets owned info is not yet populated.