search

aiannacc / Goko-Salvager

Enhance your Dominion Online experience!
13 stars 9 forks source link

Better end turn #239

Closed michaeljb closed 10 years ago

michaeljb commented 10 years ago

Replaces Goko's "End Turn" button with one in the Salvager sidebar, should reduce the chance of ending your turn by misclick.

Also includes a JSLint setting tweak so that everything passes JSLint again.

Tested in latest Chrome and Firefox on OS X Mavericks.

aiannacc commented 10 years ago

I'm confused. I don't see any change. endturn

Testing on Chromium 33 on Arch Linux.

michaeljb commented 10 years ago

Did you check "Better End Turn button" in the settings dialog? It's under the "Game" tab.

aiannacc commented 10 years ago

Duh. Okay. Great work!

michaeljb commented 10 years ago

Thanks! :+1:

theblankman commented 10 years ago

Just tried this on Chrome 35, OSX 10.9.3, and I was seeing multiples of the new "End Turn" button. They all worked, there was just a row of them, one for each game I played with the option on, like so: screen shot 2014-05-27 at 1 58 28 am I added a comment to the commit where I think the issue is.