Closed michaeljb closed 10 years ago
Gonna pull this and play some games with it some tonight. Can I request that if it's merged to beta, we not delete the branch like usual, but keep it around to continue working on #241? Or would it be better to create a new branch after we merge this?
Definitely better to create a new branch before your merge, but I think it'd be easier to answer your question if I knew your goal.
It sounds like we'll end up replacing all Goko's buttons under #241, I was just asking whether we should keep this branch to do that or make a new one. I guess the answer is make a new one. BTW this is looking good over several games, I'll probably merge it whenever I stop playing tonight.
Ah. Yes, lots and lots of branches. :)
started a game with silverspawn with my vpcounter on but not locked, he requested #vpoff in chat, and this happened...
Replicated in another game with a bot, started with vpcounter on then disabled it from chat myself. I'm committing a quick-and-dirty fix that puts the buttons left-justified above the VP counter (if it exists) and the log. Feel free to replace it with something better. Or we could release it like this and say it'll get prettier when we do the larger button replacement. Here's how I have it now...
vpoff:
vpon:
Everything looks good to me. I'll release it into the beta.
Since "End Actions" was requested and received upvotes, I figure we might as well get this in to the beta branch sooner rather than later, even if our discussion in #241 ends up changing the alternate buttons substantially.