search

aiannacc / Goko-Salvager

Enhance your Dominion Online experience!
13 stars 9 forks source link

Add "Formula for modified card frequencies" to kingdom generator. #248

Closed michaeljb closed 10 years ago

michaeljb commented 10 years ago

As requested in the first reply in the thread.

Additionally, GS.template() always calls GS.debug(), and the HTML for the kingdom generator is in its own template, rather than a messy js string.

I didn't change any versioning anywhere, @aiannacc will probably want that changed before releasing?

aiannacc commented 10 years ago

Very nice! I'll test and publish this to the beta later today.

And yes, I'll increment the version. You're probably right that It's best to just add the code and let me do the versioning when I push updates.

Two possible additions:

  1. Cache the player's more/less/never lists or add them to their user settings
  2. Add buttons for one or more simple defaults (e.g. use Scout, Thief, etc for the "less" list) or the set I specified in my OP (and a link to it).

Regarding your comment on "as the feature grows:" I think you're right about the need for some error-checking, but I really don't want to see this feature grow much more. Or rather, I'd far prefer to somehow get out from under the kingdom generator formula. It's incredible unnatural to use, despite its mathematical purity. Modifying the interface as you have is a step in the right direction, imo.

aiannacc commented 10 years ago

Tested on Chrome. Works great.

Nice catch making both "Moat + Chapel" and "Moat, Chapel" turn into the same correct formula. On the other hand, I can also type "Moat + Weasel" and it blithely generates a formula that will give me 300% more weasels. :)