search

aibasel / machetli

GNU General Public License v3.0
6 stars 3 forks source link

#55 refactor how batches in search are handled #86

Closed FlorianPommerening closed 1 year ago

FlorianPommerening commented 1 year ago

remove batch_id from Environment.submit() and use a better way of batching states in the search

FlorianPommerening commented 1 year ago

Thanks for the review. I pushed one more change into this (d44c6663) to fix #70. I think it fits the theme of cleaning up the environment and didn't want two competing pull requests that conflict with each other.

ClemensBuechner commented 1 year ago

I think d44c666 was already part of what I reviewed, so it didn't influence my approval for this issue/pull request.

FlorianPommerening commented 1 year ago

Ok, I'll merge then, and close the issues.