search

aibreania / Dashboard

A dashboard written in ReactJS, ES6, SCSS, Webpack.
0 stars 0 forks source link

Code Review #1

Open levi-art-rules opened 7 years ago

levi-art-rules commented 7 years ago

Good Job!

I'll give a code review in detail this afternoon.

levi-art-rules commented 7 years ago

Task Description:

The assignment was designed to test the interviewer's knowledge of basic HTML/CSS/JS, project-related technology stack (mainly React and SCSS), and some other CS fundamentals including but not limited to OOP and software design.

Comment:

She finished the task in roughly 2 weeks, presenting a demo that has all required elements that are in the design sketch.

Outstanding: N/A

Exceeds Expectation:

  1. She is a faster learner. We had a couple of Wechat discussions and Skype meetings for possible improvements, including how to design code structure for large projects, page loading optimization and scalability. She proves to be a student that can quickly accept new knowledge and use it in work.
  2. She is a good team player. She knows when and how to ask questions to help boost up the productivity for her and the whole team.
  3. She has basic knowledge of GIT and cloud hosting.

Meets Expectation:

  1. She has basic knowledge of HTML/CSS/JS and React.
  2. She has CS fundamentals and web development basics that meet our criteria.

Needs Improvements:

  1. She took longer time( my previous requirement of 1 week) to finish the project, which is because of the following reasons.
  2. She doesn't have experience of how to develop a modern web app in general, and lacks knowledge of current web tech ecology.
  3. She seems to know some trending technology in the field but doesn't have working experience of any of them (React/Redux, SCSS, Webpack).
  4. She doesn't have framework level thinking, even though I hinted it several times in our meetings and discussions.

Poor: N/A

Conclusion: She has the potential to be a productive member for our project. However, she needs at least a month to pick up the work, and get used to our working pace and workload.