aic-sri-international / aic-expresso

SRI International's AIC Symbolic Manipulation and Evaluation Library (for Java 1.8+)
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

Some rewriters tracing in and out messages being filtered out without apparent reason #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I noticed that some rewriters tracing in and out don't show up. The one I 
noticed explicitly was lpb.R_simplify. Its name is *not* in the 
aic-smf-config.xml file (entry 
grinder.rewriting.filter.out.logging.by.rewriters.named). I also have ins and 
outs of atomic rewriters set to true (even though that rewriter is not atomic). 
Its atomic rewriters, BTW, do show up. lbp.R_simplify is an 
AbstractHierarchicalRewriter, so by default the in and out should be on.

I also noticed that the ins and outs of some of my new hierarchical rewriters 
are not showing: IfThenElseExternalizationHierarchical, 
MoveAllRandomVariableValueExpressionConditionsDownHierarchical, 
BreakConditionsContainingBothLogicalAndRandomVariablesHierarchical. Please note 
these are not named according to the lbp.* pattern you were following, but 
named the way I used to do (using the class name).

One hypothesis I considered was that rewriters derived from 
AbstractHierarchicalRewriter would not having their in and out traced, but 
several others are, including one I wrote recently, praise.Normalize.

I am committing my current aic-smf-config.xml, which is not filtering these 
guys. I left a commented out line of the configuration in which they are 
filtered, for convenience.

Original issue reported on code.google.com by rodrigob...@gmail.com on 7 Jan 2014 at 2:46

GoogleCodeExporter commented 9 years ago
Taking ownership for.

Original comment by ctjoreilly@gmail.com on 7 Jan 2014 at 4:17

GoogleCodeExporter commented 9 years ago
Fix applied to aic-praise Subversion rev=1134.
Note: This was a configuration issue in the aic-praise project. Desired 
configuration changes were made to aic-smf-config.xml. However, this 
configuration file is only used by any of the aic-praise applications. To 
configure test output (this is what is assumed to have been looked out and 
considered incorrect), changes need to be made to the aic-smf-config-test.xml.

Original comment by ctjoreilly@gmail.com on 10 Jan 2014 at 3:27