search

aica-technology / api

AICA API resources
0 stars 0 forks source link

feat: add note about signal name conventions #141

Closed domire8 closed 3 months ago

domire8 commented 3 months ago

Description

This PR solves the issue by adding a caution block to the relevant section

Review guidelines

Estimated Time of Review: 2 minutes

Checklist before merging:

domire8 commented 3 months ago

to explicitly say that the signal name in the description must match the declared signal name in the implementation.

Isn't that already the case? https://docs.aica.tech/docs/reference/custom-components/component-descriptions#signals

eeberhard commented 3 months ago

to explicitly say that the signal name in the description must match the declared signal name in the implementation.

Isn't that already the case? https://docs.aica.tech/docs/reference/custom-components/component-descriptions#signals

Yes, I was looking for an actual link, but the writing is clear enough as is.