aica-technology / api

AICA API resources
0 stars 0 forks source link

fix: invalid nesting of required properties in schema 1-4-0 #151

Closed eeberhard closed 2 months ago

eeberhard commented 2 months ago

Description

After #146 introduced controller events to the application schema with a missing closing bracket, #148 "fixed" this problem but added the closing bracket in the wrong place. As a result, the required properties were nested under the controller and hardware properties, rather than being next to them.

Overly simplified view of how the incorrect nesting for required properties looked after #148:

hardware: {
  properties: {
    controllers: {
      properties: {
        events: {
          ...
        },
        required: [ ],
      },
    },
    required: [ ]
  }
}

Overly simplified view of how the correct nesting for required properties should look (fixed in this PR):

hardware: {
  properties: {
    controllers: {
      properties: {
        events: {
          ...
        }
      },
      required: [ ],
    }
  },
  required: [ ]
}

Since the previous deployment of schema 1-4-0 failed to validate existing applications, this PR revokes and replaces the statically generated schema with the correctly intended version of 1-4-0.

Review guidelines

Estimated Time of Review: 2 minutes

Checklist before merging: