search

aicenter / ConditionalDists.jl

Conditional probability distributions powered by DistributionsAD.jl
MIT License
21 stars 4 forks source link

safe variance #9

Closed vitskvara closed 4 years ago

vitskvara commented 4 years ago

Maybe we could solve #3 simply like this? I have ran into this issue with conv nets as well.

codecov-io commented 4 years ago

Codecov Report

Merging #9 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files           8        8           
  Lines         103      103           
=======================================
  Hits           90       90           
  Misses         13       13
Impacted Files Coverage Δ
src/cmeanvar_gaussian.jl 76.19% <100%> (ø) :arrow_up:
src/cmean_gaussian.jl 85% <100%> (ø) :arrow_up:
src/gaussian.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f77b790...35385aa. Read the comment docs.

nmheim commented 4 years ago

Fine with me. The other mean functions would just need to be changed as well

vitskvara commented 4 years ago

I added the constant also to cmean_gaussian, is there any other place it needs to go to?

nmheim commented 4 years ago

It should also go in the normal Gaussian I think :)

nmheim commented 4 years ago

thank you! :)