aicers / crusher

Crusher generates statistics from raw events
Apache License 2.0
0 stars 0 forks source link

Reload configuration upon receiving configuration-updated-notification #112

Open sophie-cluml opened 3 weeks ago

sophie-cluml commented 3 weeks ago

Background

The Manager will send "config updated" notifications to agents, whenever the configuration for that agent is updated.

Task

We need to implement the agent's side of receiving the notification. The interface function for this is review-protocol's request::Handler::update_config

Upon receiving the notification, Crusher will only reload the configuration, not finishing its process. (i.e. PID will not change.)

danbi2990 commented 1 week ago

Based on the previous discussion, it appears that the log_dir set by the Manager server remains fixed and does not change dynamically during runtime. (Or is there another way to modify the log_dir besides UI?)

Could you confirm if this assumption is correct?

danbi2990 commented 1 week ago

As discussed in Slack, the log_dir can be changed, and Crusher will respond to the update accordingly.