search

aicers / giganto

Raw-Event Storage System for AICE
Apache License 2.0
5 stars 2 forks source link

Remove humantime #782

Closed Salanoid closed 1 month ago

Salanoid commented 1 month ago

Fix for: Remove unnecessary dependency #781

sophie-cluml commented 1 month ago

Hello Salanoid, thank you for your interest and contribution in this project. In the current codebase, humantime-serde is directly used, so I think we can remove humantime, but need to keep humantime-serde.

Salanoid commented 1 month ago

Thank you for the reply, I have added the humantime-serde back.

sophie-cluml commented 1 month ago

Could you check the failing "CI / check"? I think it can be resolved by updating Cargo.lock file, which I believe can be achieved by cargo check or cargo build.

sophie-cluml commented 1 month ago

It seems like cargo update was run, and it caused update of dependency crates overall. Since we would like to focus on removing humantime for this issue, could you limit the scope of change to humantime?