search

aicers / review-web

A web interface to REview
Apache License 2.0
1 stars 2 forks source link

Delete GraphQL API `topClustersByScore` #309

Open msk opened 2 months ago

msk commented 2 months ago

I'd like to request the deletion of the GraphQL query topClustersByScore. Although this API is currently still available, it always returns an empty ClusterScoreSet, rendering its result useless.

The reason for this is that the underlying implementation relies on review_database::Database::get_top_clusters_by_score, which uses data from the csv_indicator table in the database to build the set. However, this table is no longer populated (as confirmed by @sehkone in petabi/review-database#341) and remains empty. Furthermore, it is slated for deletion from review-database in the near future.

Given that the API is not providing any meaningful data and its dependency is being removed, I propose that we delete it to avoid confusion and reduce maintenance overhead.

sehkone commented 2 months ago

Thank you for reminding me of this. I will work on it soon.

sehkone commented 2 months ago

Pending because I realized the UI should be modified accordingly before doing this.