aichaos / rivescript-js

A RiveScript interpreter for JavaScript. RiveScript is a scripting language for chatterbots.
https://www.rivescript.com/
MIT License
377 stars 145 forks source link

Include error message when error raised by object macro #341

Closed gleuch closed 4 years ago

gleuch commented 4 years ago

This PR includes the error message in the response when error is raised within an object macro.

When an error is raised in an object, the error message is included along with the default error response, e.g. [ERR: Error when executing JavaScript object: TypeError]. Very useful for debugging & testing!

However, when an error is raised in an async object macro, instead of returning the above default error reply, it only returns [ERR: Error raised by object macro]. Adding error message to follow similar pattern above.

Test added to cover this.

👉 Take note of the misspelling in the tests of asyc that was preventing await tests from running.

kirsle commented 4 years ago

Thank you!