I really like the idea, with the middleware functions.
But if we include this feature, you should work on the src/index.js file and not on the compiled lib/index.js file. You can work on the src/index.js and use npm run babel to compile it, but you should run npm test before you commit. If tests are not passing then you need to make sure that you resolve all conflicts, before you commit. The tests are failing because the linting didn't pass. So make sure to follow the airbnb javascript styleguide. Also if you add a new feature to the package you need to add a test to test this new feature.
Why should we use a | as separator? Wouldn't it be more readable with something like => or -> since it is a middleware wich passes on to the next function?
Thanks for your contribution, it would be great if you can include this feature with passing tests.
aichbauer
commented
7 years ago
I really like the idea, with the middleware functions.
But if we include this feature, you should work on the
src/index.jsfile and not on the compiledlib/index.jsfile. You can work on thesrc/index.jsand usenpm run babelto compile it, but you should runnpm testbefore you commit. If tests are not passing then you need to make sure that you resolve all conflicts, before you commit. The tests are failing because the linting didn't pass. So make sure to follow the airbnb javascript styleguide. Also if you add a new feature to the package you need to add a test to test this new feature.Why should we use a
|as separator? Wouldn't it be more readable with something like=>or->since it is a middleware wich passes on to the next function?Thanks for your contribution, it would be great if you can include this feature with passing tests.