search

aichingm / lonewolf

Organize and track your tasks with ease and flexibility
GNU General Public License v3.0
27 stars 1 forks source link

An icon (`32x32.png`) seems to be missing for the tauri context #5

Closed felix91gr closed 1 year ago

felix91gr commented 1 year ago

Okay so this is what I see:

image

I'm not sure how to fix it. The Makefile mentions no image under that name: 32x32.png.

But if we go look at lonewolf-tauri/src-tauri/tauri.conf.json, at lines 53-57 we do seem to find the cause:

https://github.com/aichingm/lonewolf/blob/afff8b5254628e45822bbe46793cb3788f0ed574/lonewolf-tauri/src-tauri/tauri.conf.json#L53-L57

Indeed, if I delete line 53, the error changes:

image

I think this error makes sense, since if we look at lonewolf-tauri/src-tauri/icons, we find only 512x512-lonewolf.png.

If I delete the lines 53-57 and replace them by just "icons/512x512-lonewolf.png", the result I get is this:

image

I'm still not certain the .deb binary I made is correct, but the change does seem to appease the build script.

aichingm commented 1 year ago

All those icons should be created with make icons-tauri. The tauri command npm run tauri icon creates them.

https://github.com/aichingm/lonewolf/blob/afff8b5254628e45822bbe46793cb3788f0ed574/Makefile#L207-L207

felix91gr commented 1 year ago

Ah, I see. Indeed, that's what was missing. Thank you :)