search

aickin / shrink-ray

Node.js compression middleware
MIT License
268 stars 21 forks source link

Delete compression version history from HISTORY.md #7

Open mikemaccana opened 7 years ago

mikemaccana commented 7 years ago

This module is excellent! brotli's going, the config is intuitive, and documentation are excellent.

One minor nitpick: the version's not consistent.

According to https://github.com/aickin/shrink-ray/blob/master/HISTORY.md it's 1.6.1

According to https://www.npmjs.com/package/shrink-ray it's 0.1.3

Maybe update both and publish 1.6.2 on npm (as the module seems pretty stable now and 1.6.2 is more semver-y).

aickin commented 7 years ago

Thanks Mike!

The 1.6.x versions are the versions of compression (which this was forked from) whereas 0.1.3 is the version of this (shrink-ray). I guess I should modify HISTORY.md to reflect this project only; I'll change the title of this issue. Thanks!

mikemaccana commented 7 years ago

Since this project is mature, it could be good release a new version with a post-1.x version. 0.1.3 can seem a bit experimental. Maybe 2.0 since it's a breaking change from the old compression module?

From: Sasha Aickin notifications@github.com Sent: Wednesday, April 5, 2017 11:26:30 PM To: aickin/shrink-ray Cc: Mike MacCana; Author Subject: Re: [aickin/shrink-ray] Is latest version 1.6.1 or 0.1.3? (#7)

Thanks Mike!

The 1.6.x versions are the versions of compression (which this was forked from) whereas 0.1.3 is the version of this (shrink-ray). I guess I should modify HISTORY.md to reflect this project only; I'll change the title of this issue. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/aickin/shrink-ray/issues/7#issuecomment-292015344, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAKiMvdjLrziNvfdER4cKK9BS27cslw8ks5rtBUWgaJpZM4MzPpI.