search

aicoe-aiops / cloud-price-analysis-public

GNU General Public License v3.0
18 stars 17 forks source link

Fix pre-commit #23

Closed aakankshaduggal closed 2 years ago

aakankshaduggal commented 2 years ago

Related Issues and Dependencies

Related-to #20

This introduces a breaking change

This Pull Request implements

… Explain your changes.

Description

sesheta commented 2 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - exit code: 1 Traceback (most recent call last): File "/tekton/home/.cache/pre-commit/repow1i64ihs/py_env-python3/bin/black-nb", line 5, in from black_nb.cli import cli File "/tekton/home/.cache/pre-commit/repow1i64ihs/py_env-python3/lib/python3.6/site-packages/black_nb/cli.py", line 17, in import regex as re ModuleNotFoundError: No module named 'regex' flake8-nb................................................................Passed ```
sesheta commented 2 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - exit code: 1 Traceback (most recent call last): File "/tekton/home/.cache/pre-commit/repowpb6mkqk/py_env-python3/bin/black-nb", line 5, in from black_nb.cli import cli File "/tekton/home/.cache/pre-commit/repowpb6mkqk/py_env-python3/lib/python3.6/site-packages/black_nb/cli.py", line 17, in import regex as re ModuleNotFoundError: No module named 'regex' flake8-nb................................................................Passed ```
sesheta commented 2 years ago

@aakankshaduggal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit 37763eb1431d4e9b934a0484ecc244787efda7ac link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
harshad16 commented 2 years ago

Merging this , will check on the pre-commit in another pr.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16 To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/cloud-price-analysis-public/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment