search

aicoe-aiops / cloud-price-analysis-public

GNU General Public License v3.0
18 stars 17 forks source link

Ec2 json files #54

Closed AdiY10 closed 2 years ago

AdiY10 commented 2 years ago

Related Issues and Dependencies

…

This introduces a breaking change

This Pull Request implements

… Explain your changes.

Description

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign ilya-kolchinsky after the PR has been reviewed. You can assign the PR to them by writing /assign @ilya-kolchinsky in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/cloud-price-analysis-public/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

Hi @AdiY10. Thanks for your PR.

I'm waiting for a aicoe-aiops member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.