search

aicoe-aiops / fedora-mailing-list-analysis

This will be the repo for the Fedora mailing list sentiment analysis project
Other
0 stars 2 forks source link

WIP on retrieving the mbox files from the fedora archives. #10

Closed cdolfi closed 3 years ago

cdolfi commented 3 years ago

This is a WIP on getting the mbox from fedora archives. I am looking to see if there is a way to do this without having to save locally. Also, I have ran into a small issue that at times that sometimes the gzip sometimes does not always get the entire archive but that also happens at times when you do it manually. The last two tries worked successfully.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

oindrillac commented 3 years ago

@cdolfi I think your changes look good :tada: I think this notebook looks ready to add after making the minor suggested changes(please see comments).

oindrillac commented 3 years ago

@cdolfi thanks for adding the Pipfile. For notebook linting you can use flake8-nb. On a quick glance I couldnt spot many errors other than the unused import statements, but running it through a lint check might help. Once that is done, you can remove the WIP tag from the PR, and it should be ready for review/merge.