search

aicoe-aiops / ocp-alert-prediction-public

0 stars 2 forks source link

Create JH demo image #4

Open oindrillac opened 4 years ago

oindrillac commented 4 years ago

should we make the repo available as a deployed image on JupyterHub

chauhankaranraj commented 4 years ago

I like that idea! Although, some of the notebooks in this repo's non-public counterpart cannot be added here, as they might have some sensitive info (how to identify CI/CD vs production clusters). Should we make non-public repo available as an image then?

oindrillac commented 4 years ago

sure, let's do that then :)

MichaelClifford commented 4 years ago

Question about this: if jupyterhub is currently non-public, then why would we make another image of a public version of an existing non-public image to deploy there? It seems like it would be confusing. but maybe I'm misunderstanding the issue :smiley:

chauhankaranraj commented 4 years ago

Question about this: if jupyterhub is currently non-public, then why would we make another image of a public version of an existing non-public image to deploy there?

AFAIK for the alert prediction problem there's no image, public or non-public, available on jupyterhub rn.

So I think (correct me if I'm wrong) @oindrillac was suggesting adding an image with those notebooks, and I was saying to use the non-public repo for that instead of this one. Do you think that'd make sense?

MichaelClifford commented 4 years ago

That makes more sense : ) thanks for the clarification @chauhankaranraj

MichaelClifford commented 3 years ago

@chauhankaranraj does the openshift-anomaly-detection:latest image on MOC-JH mean we can close this issue?