search

aicoe-aiops / project-template

this is a template to use for new data science projects in the aiops group
Other
8 stars 21 forks source link

Describe Github templates #46

Closed pacospace closed 2 years ago

pacospace commented 2 years ago

Signed-off-by: Francesco Murdaca fmurdaca@redhat.com

Fixes: https://github.com/thoth-station/support/issues/91

Related-To: https://github.com/aicoe-aiops/project-template/issues/45

sesheta commented 2 years ago

Hi @pacospace. Thanks for your PR.

I'm waiting for a aicoe-aiops member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pacospace commented 2 years ago

/assign @MichaelClifford

MichaelClifford commented 2 years ago

This looks good, but should we add the updated text to the issue templates themselves? That way the information persists and is presented to users before each issue is created. This repo outline readme is often overwritten once a project gets started and this info will no longer be visible to users.

pacospace commented 2 years ago

This looks good, but should we add the updated text to the issue templates themselves? That way the information persists and is presented to users before each issue is created. This repo outline readme is often overwritten once a project gets started and this info will no longer be visible to users.

Yes definitely better to have it also there, I will add it in this PR, thanks @MichaelClifford

pacospace commented 2 years ago

updated! @MichaelClifford please have a look!

MichaelClifford commented 2 years ago

Thanks @pacospace /approve

pacospace commented 2 years ago

/assign @tumido /assign @durandom

@MichaelClifford should we add more approvers/reviewers?

MichaelClifford commented 2 years ago

I was just about to update the owners file @pacospace

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelClifford, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/aicoe-aiops/project-template/blob/master/OWNERS)~~ [tumido] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

New changes are detected. LGTM label has been removed.