Application cannot be managed by Kebechet due to it containing an unsupported package location.

aicoe-aiops / project-template

this is a template to use for new data science projects in the aiops group

Other

8 stars 21 forks source link

Application cannot be managed by Kebechet due to it containing an unsupported package location. #48

Open khebhut[bot] opened 2 years ago

khebhut[bot] commented 2 years ago

Kebechet cannot support maintaining this application as it contain's local version of packages.

The package causing the issue is - src Linked SHA - 17ae6d989d015e35ce6789a57bf7b0df14b95e22

For more information, see Pipfile and Pipfile.lock.

Environment details

``` Kebechet version: 1.5.5 Python version: 3.8.6 Platform: Linux-4.18.0-305.19.1.el8_4.x86_64-x86_64-with-glibc2.2.5 pipenv version: pipenv, version 2020.11.15 ```

/kind bug /priority critical-urgent

MichaelClifford commented 2 years ago

@pacospace @harshad16 The Pipfile.lock as not changed in the past 7 months, but this issue was created today. Do we need to address this issue now? or was it created in error? Since this is the template repo, I'm assuming this issue is relevant to all ai-coe org projects?

tumido commented 2 years ago

Bump @harshad16 ^

pacospace commented 2 years ago

Cc @KPostOffice

KPostOffice commented 2 years ago

@pacospace @harshad16 The Pipfile.lock as not changed in the past 7 months, but this issue was created today. Do we need to address this issue now? or was it created in error? Since this is the template repo, I'm assuming this issue is relevant to all ai-coe org projects?

@MichaelClifford This is something that I updated the other day. Kebechet update manager fails when trying to manage dependencies which are local, so I explicitly created this issue to warn users.

MichaelClifford commented 2 years ago

Is the src package in the pipfile the culprit? https://github.com/aicoe-aiops/project-template/blob/17ae6d989d015e35ce6789a57bf7b0df14b95e22/Pipfile#L12

KPostOffice commented 2 years ago

Is the src package in the pipfile the culprit?

https://github.com/aicoe-aiops/project-template/blob/17ae6d989d015e35ce6789a57bf7b0df14b95e22/Pipfile#L12

Yeah, exactly

JamesKunstle commented 2 years ago

@MichaelClifford @KPostOffice I'm fixing this issue on our end- would it be possible to have a brief explanation of why 'src' is in the Pipfile and whether simply removing that line will fix the problem?

MichaelClifford commented 2 years ago

@JamesKunstle yes, I believe removing that line from the Pipfile should fix the problem. As to why it is in there? it looks to be a hold over from one of the fist PR's converting a requirements.txt to a Pipfile #1 .

Also, #50 indicates that its used for notebook based development.

I'll add a PR to remove this from the template going forward. Thanks!

JamesKunstle commented 2 years ago

@MichaelClifford
Thanks so much for the explanation and for the PR! This fixes our issue with Kebechet in one shot.