search

aicoe-aiops / time-series

A repository showing example analysis of time series data.
Other
5 stars 8 forks source link

Add concepts notebook #16

Closed Shreyanand closed 3 years ago

Shreyanand commented 3 years ago

Related Issues and Dependencies

fixes #15

This introduces a breaking change

Description

In this PR, I add the third notebook in the time series project. In this notebook, we study and experiment with the statistical tools used for time series data. We begin with examining characteristics of a time series followed by modelling it. This notebook can be used as a guideline to analyze, understand, and model any time series data.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sesheta commented 3 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook reformatted notebooks/ts-3-concepts.ipynb 26 cells reformatted, 30 cells left unchanged. 17 cells left unchanged. 11 cells left unchanged. All done! 1 file reformatted, 2 files left unchanged. flake8-nb................................................................Failed - hook id: flake8-nb - exit code: 1 notebooks/ts-3-concepts.ipynb#In[1]:3:1: F401 'prometheus_api_client.utils.parse_datetime' imported but unused notebooks/ts-3-concepts.ipynb#In[1]:6:1: F401 'IPython.display.Image' imported but unused notebooks/ts-3-concepts.ipynb#In[1]:7:1: F401 'plotly.graph_objects as go' imported but unused notebooks/ts-3-concepts.ipynb#In[19]:2:6: N802 function name 'LLR_test' should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:2:29: N803 argument name 'DF' should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:3:6: N806 variable 'L1' in function should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:3:6: N806 variable 'L2' in function should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:4:6: N806 variable 'LR' in function should be lowercase notebooks/ts-3-concepts.ipynb#In[33]:7:5: E722 do not use bare 'except' notebooks/ts-3-concepts.ipynb#In[44]:14:5: E722 do not use bare 'except' ```
sesheta commented 3 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook 17 cells left unchanged. reformatted notebooks/ts-3-concepts.ipynb 26 cells reformatted, 30 cells left unchanged. 11 cells left unchanged. All done! 1 file reformatted, 2 files left unchanged. flake8-nb................................................................Failed - hook id: flake8-nb - exit code: 1 notebooks/ts-3-concepts.ipynb#In[1]:3:1: F401 'prometheus_api_client.utils.parse_datetime' imported but unused notebooks/ts-3-concepts.ipynb#In[1]:6:1: F401 'IPython.display.Image' imported but unused notebooks/ts-3-concepts.ipynb#In[1]:7:1: F401 'plotly.graph_objects as go' imported but unused notebooks/ts-3-concepts.ipynb#In[19]:2:6: N802 function name 'LLR_test' should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:2:29: N803 argument name 'DF' should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:3:6: N806 variable 'L1' in function should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:3:6: N806 variable 'L2' in function should be lowercase notebooks/ts-3-concepts.ipynb#In[19]:4:6: N806 variable 'LR' in function should be lowercase notebooks/ts-3-concepts.ipynb#In[33]:7:5: E722 do not use bare 'except' notebooks/ts-3-concepts.ipynb#In[44]:14:5: E722 do not use bare 'except' ```
Shreyanand commented 3 years ago

Update: I have also added a snapshot of a dataset to ensure reproduciblity across different runs. The model hyper parameters will change if we fetch the data in real time making some of the cells meaningless.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-02-22T19:35:24Z ----------------------------------------------------------------

Can you chance the y-axis to say "value" and the the x-axis t o say "time" I don think "white noise" is strictly correct here. Same with the plot below.


review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-02-22T19:35:25Z ----------------------------------------------------------------

Can you make sure this plot is the same size as the rest.


MichaelClifford commented 3 years ago

@Shreyanand Looks good! just made 2 really small graphing suggestions.

Shreyanand commented 3 years ago

@Shreyanand Looks good! just made 2 really small graphing suggestions.

Done, thanks :+1:

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.