Add Linear and Exponential models

[aakankshaduggal]

Related Issues and Dependencies

17

This notebook adds Linear and Exponential models for timeseries data.

This introduces a breaking change

• [ ] Yes
• [x] No

This Pull Request implements

… Explain your changes.

Description

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[sesheta]

Pre-Commit Test failed! Click here

``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook reformatted notebooks/ts-3-concepts.ipynb 18 cells reformatted, 61 cells left unchanged. 11 cells left unchanged. 17 cells left unchanged. All done! 1 file reformatted, 2 files left unchanged. flake8-nb................................................................Failed - hook id: flake8-nb - exit code: 1 notebooks/ts-3-concepts.ipynb#In[1]:7:1: F401 'sklearn.datasets' imported but unused notebooks/ts-3-concepts.ipynb#In[1]:8:1: F401 'statsmodels.tsa.api.ExponentialSmoothing' imported but unused notebooks/ts-3-concepts.ipynb#In[33]:9:121: E501 line too long (122 > 120 characters) notebooks/ts-3-concepts.ipynb#In[33]:12:121: E501 line too long (123 > 120 characters) ```

[sesheta]

Pre-Commit Test failed! Click here

``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook reformatted notebooks/ts-3-concepts.ipynb 18 cells reformatted, 61 cells left unchanged. 11 cells left unchanged. 38 cells left unchanged. 17 cells left unchanged. All done! 1 file reformatted, 3 files left unchanged. flake8-nb................................................................Failed - hook id: flake8-nb - exit code: 1 notebooks/ts-3-concepts.ipynb#In[1]:7:1: F401 'sklearn.datasets' imported but unused notebooks/ts-3-concepts.ipynb#In[1]:8:1: F401 'statsmodels.tsa.api.ExponentialSmoothing' imported but unused notebooks/ts-3-concepts.ipynb#In[33]:9:121: E501 line too long (122 > 120 characters) notebooks/ts-3-concepts.ipynb#In[33]:12:121: E501 line too long (123 > 120 characters) ```

[sesheta]

Pre-Commit Test failed! Click here

``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook reformatted notebooks/ts-3-concepts.ipynb 11 cells reformatted, 63 cells left unchanged. 11 cells left unchanged. 38 cells left unchanged. 17 cells left unchanged. All done! 1 file reformatted, 3 files left unchanged. flake8-nb................................................................Passed ```

[sesheta]

Pre-Commit Test failed! Click here

``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook 38 cells left unchanged. 17 cells left unchanged. reformatted notebooks/ts-3-concepts.ipynb 11 cells reformatted, 63 cells left unchanged. 11 cells left unchanged. All done! 1 file reformatted, 3 files left unchanged. flake8-nb................................................................Passed ```

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:51Z ----------------------------------------------------------------

I think you accidentally removed the headings... Add the new methods in the content section as well.

aakankshaduggal commented on 2021-04-20T15:52:52Z ----------------------------------------------------------------

Oh my bad. I will add that section with the updated list.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:51Z ----------------------------------------------------------------

I think if we set the size before plotting it, this will become as big as others as well...

aakankshaduggal commented on 2021-04-20T15:53:07Z ----------------------------------------------------------------

Yeah. I will fix this

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:52Z ----------------------------------------------------------------

The next model we explore is ...

You could also add here that "Linear regression models the linear relationship of predictors whereas ARIMA models the linear relationship of past observation. This makes ARIMA naturally adaptive to new data [source]"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:53Z ----------------------------------------------------------------

Change this to "This doesn't work. Let's try for orders lesser than 4,4."

aakankshaduggal commented on 2021-04-20T16:29:11Z ----------------------------------------------------------------

Should I just remove this and write a comment instead.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Change to "ARMA(4,3) and ARMA(3,3) have low AIC, with all significant coefficients. Both of these models are good candidates for fitting the series"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Some models are failing to converge. Looking at the logs and the error message, it seems that the optimization algorithm used (LBFGSB) may work differently for different systems. Changing to a simpler model ARIMA(3,1,1) will work here.

aakankshaduggal commented 3 years ago

Oh my bad. I will add that section with the updated list.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Yeah. I will fix this

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Should I just remove this and write a comment instead.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@Shreyanand Thanks for the review. The issues with the old models are now resolved.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

do you want to plot this line against the test and training data so readers can see what the output of linear regression looks like? Also if you are going to split it into train and test, do you want to evaluate your linear model on the test data?

aakankshaduggal commented on 2021-04-20T18:47:51Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:51Z ----------------------------------------------------------------

I think if we set the size before plotting it, this will become as big as others as well...

aakankshaduggal commented on 2021-04-20T15:53:07Z ----------------------------------------------------------------

Yeah. I will fix this

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:52Z ----------------------------------------------------------------

The next model we explore is ...

You could also add here that "Linear regression models the linear relationship of predictors whereas ARIMA models the linear relationship of past observation. This makes ARIMA naturally adaptive to new data [source]"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:53Z ----------------------------------------------------------------

Change this to "This doesn't work. Let's try for orders lesser than 4,4."

aakankshaduggal commented on 2021-04-20T16:29:11Z ----------------------------------------------------------------

Should I just remove this and write a comment instead.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Change to "ARMA(4,3) and ARMA(3,3) have low AIC, with all significant coefficients. Both of these models are good candidates for fitting the series"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Some models are failing to converge. Looking at the logs and the error message, it seems that the optimization algorithm used (LBFGSB) may work differently for different systems. Changing to a simpler model ARIMA(3,1,1) will work here.

aakankshaduggal commented 3 years ago

Oh my bad. I will add that section with the updated list.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Yeah. I will fix this

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Should I just remove this and write a comment instead.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@Shreyanand Thanks for the review. The issues with the old models are now resolved.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

do you want to plot this line against the test and training data so readers can see what the output of linear regression looks like? Also if you are going to split it into train and test, do you want to evaluate your linear model on the test data?

aakankshaduggal commented on 2021-04-20T18:47:51Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:52Z ----------------------------------------------------------------

The next model we explore is ...

You could also add here that "Linear regression models the linear relationship of predictors whereas ARIMA models the linear relationship of past observation. This makes ARIMA naturally adaptive to new data [source]"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:53Z ----------------------------------------------------------------

Change this to "This doesn't work. Let's try for orders lesser than 4,4."

aakankshaduggal commented on 2021-04-20T16:29:11Z ----------------------------------------------------------------

Should I just remove this and write a comment instead.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Change to "ARMA(4,3) and ARMA(3,3) have low AIC, with all significant coefficients. Both of these models are good candidates for fitting the series"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Some models are failing to converge. Looking at the logs and the error message, it seems that the optimization algorithm used (LBFGSB) may work differently for different systems. Changing to a simpler model ARIMA(3,1,1) will work here.

aakankshaduggal commented 3 years ago

Oh my bad. I will add that section with the updated list.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Yeah. I will fix this

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Should I just remove this and write a comment instead.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@Shreyanand Thanks for the review. The issues with the old models are now resolved.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

do you want to plot this line against the test and training data so readers can see what the output of linear regression looks like? Also if you are going to split it into train and test, do you want to evaluate your linear model on the test data?

aakankshaduggal commented on 2021-04-20T18:47:51Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:53Z ----------------------------------------------------------------

Change this to "This doesn't work. Let's try for orders lesser than 4,4."

aakankshaduggal commented on 2021-04-20T16:29:11Z ----------------------------------------------------------------

Should I just remove this and write a comment instead.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Change to "ARMA(4,3) and ARMA(3,3) have low AIC, with all significant coefficients. Both of these models are good candidates for fitting the series"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Some models are failing to converge. Looking at the logs and the error message, it seems that the optimization algorithm used (LBFGSB) may work differently for different systems. Changing to a simpler model ARIMA(3,1,1) will work here.

aakankshaduggal commented 3 years ago

Oh my bad. I will add that section with the updated list.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Yeah. I will fix this

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Should I just remove this and write a comment instead.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@Shreyanand Thanks for the review. The issues with the old models are now resolved.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

do you want to plot this line against the test and training data so readers can see what the output of linear regression looks like? Also if you are going to split it into train and test, do you want to evaluate your linear model on the test data?

aakankshaduggal commented on 2021-04-20T18:47:51Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Change to "ARMA(4,3) and ARMA(3,3) have low AIC, with all significant coefficients. Both of these models are good candidates for fitting the series"

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Some models are failing to converge. Looking at the logs and the error message, it seems that the optimization algorithm used (LBFGSB) may work differently for different systems. Changing to a simpler model ARIMA(3,1,1) will work here.

aakankshaduggal commented 3 years ago

Oh my bad. I will add that section with the updated list.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Yeah. I will fix this

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Should I just remove this and write a comment instead.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@Shreyanand Thanks for the review. The issues with the old models are now resolved.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

do you want to plot this line against the test and training data so readers can see what the output of linear regression looks like? Also if you are going to split it into train and test, do you want to evaluate your linear model on the test data?

aakankshaduggal commented on 2021-04-20T18:47:51Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

Shreyanand commented on 2021-04-20T14:49:54Z ----------------------------------------------------------------

Some models are failing to converge. Looking at the logs and the error message, it seems that the optimization algorithm used (LBFGSB) may work differently for different systems. Changing to a simpler model ARIMA(3,1,1) will work here.

aakankshaduggal commented 3 years ago

Oh my bad. I will add that section with the updated list.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Yeah. I will fix this

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Should I just remove this and write a comment instead.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@Shreyanand Thanks for the review. The issues with the old models are now resolved.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

do you want to plot this line against the test and training data so readers can see what the output of linear regression looks like? Also if you are going to split it into train and test, do you want to evaluate your linear model on the test data?

aakankshaduggal commented on 2021-04-20T18:47:51Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[aakankshaduggal]

Oh my bad. I will add that section with the updated list.

---

View entire conversation on ReviewNB

[aakankshaduggal]

Yeah. I will fix this

---

View entire conversation on ReviewNB

[aakankshaduggal]

Should I just remove this and write a comment instead.

---

View entire conversation on ReviewNB

[aakankshaduggal]

@Shreyanand Thanks for the review. The issues with the old models are now resolved.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

do you want to plot this line against the test and training data so readers can see what the output of linear regression looks like? Also if you are going to split it into train and test, do you want to evaluate your linear model on the test data?

aakankshaduggal commented on 2021-04-20T18:47:51Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:29Z ----------------------------------------------------------------

Can you add plots indicating the time series models generated above?

aakankshaduggal commented on 2021-04-20T18:48:05Z ----------------------------------------------------------------

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2021-04-20T18:45:30Z ----------------------------------------------------------------

If it doesn't work maybe just remove the commented out cell and this note?

aakankshaduggal commented on 2021-04-20T18:48:19Z ----------------------------------------------------------------

Sure. I will remove this cell.

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

aakankshaduggal commented 3 years ago

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[aakankshaduggal]

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

[aakankshaduggal]

We will be covering that bit in the next notebook - forecasting. For now we are just explaining the concepts.

---

View entire conversation on ReviewNB

[aakankshaduggal]

Sure. I will remove this cell.

---

View entire conversation on ReviewNB

[aakankshaduggal]

@MichaelClifford and @Shreyanand I have added the updated notebook with suggested changes :+1:

[sesheta]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shreyanand To complete the pull request process, please assign durandom after the PR has been reviewed. You can assign the PR to them by writing /assign @durandom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment