Closed Shreyanand closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@Shreyanand Can you fix the pre-commit errors? Otherwise LGTM :+1:
Also, there is a notebook in the api client project repo which is similar to this one. Should we add the MetricRange
and MetricSnapshot
content there as well?
@Shreyanand Can you fix the pre-commit errors? Otherwise LGTM
Sure!
E402 module level import not at top of file
what is this expecting? Do imports need to be on the first line of the cell? Or before markdowns?
@Shreyanand looks great! Left a small suggestion :)
@Shreyanand Can you fix the pre-commit errors? Otherwise LGTM
Sure!
E402 module level import not at top of file
what is this expecting? Do imports need to be on the first line of the cell? Or before markdowns?
For transparency: Checked it locally, turns out that you can't put anything before import statements. Not even !pip install
commands.
/retest
/retest
Hi @4n4nd Unauthorised to run /retest command.
/retest
/approve
/retest
why didn't it work when I commented? In other news, I got ignored by a bot :laughing:
what about me?
/approve
@Shreyanand I have no idea. It ignored me for some time as well.. :smile:
And I'm not waiting for the approve label.. Let's merge it. :smile:
Related Issues and Dependencies
2
This introduces a breaking change
This Pull Request implements
This pull request adds the first notebook that describes how to fetch metrics from a Prometheus instance and create a dataframe for analysis.