search

aicoe-aiops / time-series

A repository showing example analysis of time series data.
Other
5 stars 8 forks source link

Release of version 0.1.1 #45

Closed khebhut[bot] closed 3 years ago

khebhut[bot] commented 3 years ago

Hey, @Shreyanand!

Opening this PR to fix the last release.

WARNING NOTE The release version mentioned in the source-code couldn't be found in git tags, hence the release is created from the start. If that is not the right behavior:

Closes: #44


Changelog:
### Features
* Add me as a maintainer
* Bump urllib3 from 1.26.4 to 1.26.5
* Update Owners
* Add forecasting notebook (#20)
* Bump urllib3 from 1.26.3 to 1.26.4
* Add concepts notebook (#16)
* Add changes for ODH image
* Fix links (#12)
* Update README
* Add data manipulation and visualization notebook
* Add fetching metrics notebook
### Improvements
* Add Linear and Exponential models
sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign michaelclifford after the PR has been reviewed. You can assign the PR to them by writing /assign @michaelclifford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/aicoe-aiops/time-series/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Shreyanand commented 3 years ago

@harshad16 shouldn't it have been v0.0.2 since this is a new patch release?

harshad16 commented 3 years ago

shouldn't it have been v0.0.2 since this is a new patch release?

@Shreyanand , for the bot , this is the source of truth https://github.com/aicoe-aiops/time-series/blob/1499eeddcd6884c26279bb8430f0f1671de46e8b/setup.py#L5 , while updating versions. it doesn't rely on existing tags, as that get updated and delete.

This values is what the bot try to keep up. i would suggest, closing this pr and the issue. fix this https://github.com/aicoe-aiops/time-series/blob/1499eeddcd6884c26279bb8430f0f1671de46e8b/setup.py#L5 value manually to v0.0.1 and then opening the patch release request again,

Shreyanand commented 3 years ago

shouldn't it have been v0.0.2 since this is a new patch release?

@Shreyanand , for the bot , this is the source of truth

https://github.com/aicoe-aiops/time-series/blob/1499eeddcd6884c26279bb8430f0f1671de46e8b/setup.py#L5

, while updating versions. it doesn't rely on existing tags, as that get updated and delete. This values is what the bot try to keep up. i would suggest, closing this pr and the issue. fix this

https://github.com/aicoe-aiops/time-series/blob/1499eeddcd6884c26279bb8430f0f1671de46e8b/setup.py#L5

value manually to v0.0.1 and then opening the patch release request again,

Aah ok, that makes sense, thanks :)