search

aicoe-aiops / time-series

A repository showing example analysis of time series data.
Other
5 stars 8 forks source link

Add data manipulation and visualization notebook #7

Closed Shreyanand closed 3 years ago

Shreyanand commented 3 years ago

In this PR, I add a notebook for data manipulation and visualization addressing #5.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sesheta commented 3 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook reformatted notebooks/ts-2-visualization.ipynb 13 cells reformatted, 5 cells left unchanged. All done! 1 file reformatted. flake8-nb................................................................Failed - hook id: flake8-nb - exit code: 1 notebooks/ts-2-visualization.ipynb#In[2]:1:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:2:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:3:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:4:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:5:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:6:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:7:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:7:1: F401 'os' imported but unused notebooks/ts-2-visualization.ipynb#In[2]:8:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[170]:2:2: N816 variable 'ts_D' in global scope should not be mixedCase notebooks/ts-2-visualization.ipynb#In[171]:2:2: N816 variable 'ts_H' in global scope should not be mixedCase notebooks/ts-2-visualization.ipynb#In[173]:2:2: N816 variable 'ts_UH' in global scope should not be mixedCase ```
sesheta commented 3 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Passed Check for merge conflicts................................................Passed Fix End of Files.........................................................Passed Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook reformatted notebooks/ts-2-visualization.ipynb 13 cells reformatted, 5 cells left unchanged. All done! 1 file reformatted. flake8-nb................................................................Failed - hook id: flake8-nb - exit code: 1 notebooks/ts-2-visualization.ipynb#In[2]:1:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:2:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:3:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:4:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:5:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:6:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:7:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[2]:7:1: F401 'os' imported but unused notebooks/ts-2-visualization.ipynb#In[2]:8:1: E402 module level import not at top of file notebooks/ts-2-visualization.ipynb#In[170]:2:2: N816 variable 'ts_D' in global scope should not be mixedCase notebooks/ts-2-visualization.ipynb#In[171]:2:2: N816 variable 'ts_H' in global scope should not be mixedCase notebooks/ts-2-visualization.ipynb#In[173]:2:2: N816 variable 'ts_UH' in global scope should not be mixedCase ```
tumido commented 3 years ago

/retest

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

MichaelClifford commented on 2020-11-30T20:51:54Z ----------------------------------------------------------------

Do you want to remove the # !pip install ... statements and update the pipfile with these packages?


Shreyanand commented on 2020-12-01T19:27:28Z ----------------------------------------------------------------

+1

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

chauhankaranraj commented on 2020-11-30T22:53:38Z ----------------------------------------------------------------

Small nitpick, but in line 9, can "7d" be changed to "7 days ago"? It's not entirely clear to me just by looking at parse_datetime("7d") whether the resulting timestamp is 7d into the past or future.


Shreyanand commented on 2020-12-01T19:27:37Z ----------------------------------------------------------------

+1

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

chauhankaranraj commented on 2020-11-30T22:53:39Z ----------------------------------------------------------------

I like that the descriptions for other sections (Rolling, Downsampling) mention one example use case too. Would it be possible to mention a use case for upsampling as well? i.e. "one scenario where you might use upsampling is xyz"


Shreyanand commented on 2020-12-01T19:27:54Z ----------------------------------------------------------------

+1

Shreyanand commented 3 years ago

+1

View entire conversation on ReviewNB

Shreyanand commented 3 years ago

+1

View entire conversation on ReviewNB

Shreyanand commented 3 years ago

+1

View entire conversation on ReviewNB

sesheta commented 3 years ago
Pre-Commit Test failed! Click here ``` [INFO] Initializing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Initializing environment for https://github.com/psf/black. [INFO] Initializing environment for https://github.com/tomcatling/black-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb. [INFO] Initializing environment for https://github.com/s-weigand/flake8-nb:pep8-naming. [INFO] Installing environment for git://github.com/Lucas-C/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for git://github.com/pycqa/pydocstyle.git. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/tomcatling/black-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/s-weigand/flake8-nb. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Tabs remover.............................................................Passed Trim Trailing Whitespace.................................................Failed - hook id: trailing-whitespace - exit code: 1 - files were modified by this hook Fixing requirements.txt Check for merge conflicts................................................Passed Fix End of Files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing requirements.txt Tests should end in _test.py.........................(no files to check)Skipped Check for added large files..............................................Passed check BOM - deprecated: use fix-byte-order-marker........................Passed Check for case conflicts.................................................Passed Check docstring is first.................................................Passed Check JSON...............................................................Passed Check for broken symlinks............................(no files to check)Skipped Detect Private Key.......................................................Passed Check python ast.........................................................Passed Debug Statements (Python)................................................Passed pydocstyle...............................................................Passed Check Toml...............................................................Passed Check Yaml...............................................................Passed Fix End of Files.........................................................Passed Trim Trailing Whitespace.................................................Passed mypy.....................................................................Passed black....................................................................Passed black-nb.................................................................Failed - hook id: black-nb - files were modified by this hook reformatted notebooks/ts-2-visualization.ipynb 2 cells reformatted, 15 cells left unchanged. All done! 1 file reformatted. flake8-nb................................................................Passed ```
review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

4n4nd commented on 2020-12-01T19:43:06Z ----------------------------------------------------------------

Uplsampling I think this is a spelling error


Shreyanand commented 3 years ago

1 minor spelling error, otherwise LGTM

Fixed.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.