search

aicore / template-nodejs

A template project with nodejs with pure JS
GNU Affero General Public License v3.0
3 stars 6 forks source link

Parameterize CLA check URLs #48

Closed abose closed 2 years ago

abose commented 2 years ago

Currently, the URL to obtain personal/employer CLA file is hard coded See Link here . We sould parameterize it as a github environment variable.

See docs on how to pass environment variables from action yml files: https://docs.github.com/en/actions/learn-github-actions/environment-variables

psdhanesh7 commented 2 years ago

Currently, the URL to obtain personal/employer CLA file is hard coded See Link here . We sould parameterize it as a github environment variable.

See docs on how to pass environment variables from action yml files: https://docs.github.com/en/actions/learn-github-actions/environment-variables

Issue solved in pull request https://github.com/aicore/template-nodejs/pull/49#issue-1215550697.

abose commented 2 years ago

LGTM . Thanks for contributing @psdhanesh7 Closing.