search

aidan-curtis / firehose

We are trying to put out big fires
GNU General Public License v3.0
3 stars 2 forks source link

Random Ignition not Random Across Processes #9

Closed williamshen-nz closed 2 years ago

williamshen-nz commented 2 years ago

In vectorized env. Is it because of the lambda we got. If they are different instances of FireEnv then they should be random.

I guess random rng stuff might be going on. This isn't a big problem anyways but we should fix

williamshen-nz commented 2 years ago

I think it has to do with this: https://stackoverflow.com/questions/29854398/seeding-random-number-generators-in-parallel-programs

This is where we generate random points: https://github.com/aidan-curtis/firehose/blob/main/cell2fire/firehose/helpers.py#L192

williamshen-nz commented 2 years ago

It's random enough on supercloud but not my local GPU

williamshen-nz commented 2 years ago

Solved by hack for my desktop: https://github.com/aidan-curtis/firehose/commit/5ef15eb05300001dbc0a0e0faf52e90d782c9064