search

aidanaden / solid-qr-code

Solid component to generate QR codes, based on qrcode.react
https://solid-qr-code.pages.dev/
8 stars 1 forks source link

Conflicting types VS readme documentation #121

Open jgabriel98 opened 1 month ago

jgabriel98 commented 1 month ago

The documentation gives the impression that only value prop is required, and the other ones are optional: image image

But the type definition says all are mandatory: image

jgabriel98 commented 1 month ago

I just looked at the source code, and the types seems to be correct/fixed.

Maybe you forgot to make a new release?

Anyway, thanks for the convenient software!

aidanaden commented 3 weeks ago

PS - will try and push an updated release with support for solid-start v1.

Thanks!