aidancrilly / NeSST

NeSST - Neutron Scattered Spectra Tool, ICF primary and scattered neutron spectroscopy analysis code
MIT License
3 stars 2 forks source link

Request to change DD/DT primspecmoments from variance to standard deviation #29

Closed shimwell closed 8 months ago

shimwell commented 8 months ago

Wondering if standard deviation might be a nicer value to return instead of variance.

The units could be eV which would be the same as mean instead of eV**2. This makes it easy to see the +/- with regards to energy.

Also it just so happens that openmc accepts standard deviation when defining source terms with normal distributions.

This will have some knock on consequences for methods that accept variance. But should be easy to accept standard deviation instead and do some internal conversion if needed.

aidancrilly commented 8 months ago

Variance is useful in other contexts i.e. the effect of fluid velocity variance, so I think best if primspecmoments returns both variance and standard deviation

shimwell commented 8 months ago

solved by PR #30 🎉