search

aidancrilly / NeSST

NeSST - Neutron Scattered Spectra Tool, ICF primary and scattered neutron spectroscopy analysis code
MIT License
3 stars 2 forks source link

added install and import check #4

Closed shimwell closed 11 months ago

shimwell commented 11 months ago

Hi @aidancrilly

Many thanks for making NeSST open source

I'm keen to make use of this nice package you have made.

I was wondering if the project is open to pull requests as there are a few tiny things I would be keen to contribute?

Here is a very minimal pull request that attempts to add some simple checking of the package. I'm making this first because I would be keen to update the package install process in subsequent pull requests and this test will show that the install process remains functional.

You can see the CI running successfully over here on the fork

shimwell commented 11 months ago

If this PR is welcome then I have another ready that extends the CI so that it runs the example notebook. But I wanted to go one step at a time

aidancrilly commented 11 months ago

Hi @shimwell,

It is great that you are keen to contribute to NeSST and I am very welcome to PRs.

I think CI is a good idea and I can think of a few good tests that could be included.

Feel free to add issues if there are features you'd be keen to see as well.

I look forward to future contributions