search

aidancrilly / NeSST

NeSST - Neutron Scattered Spectra Tool, ICF primary and scattered neutron spectroscopy analysis code
MIT License
3 stars 2 forks source link

Adding test for example to CI #5

Closed shimwell closed 10 months ago

shimwell commented 11 months ago

Hi @aidancrilly

Here is a tiny follow up PR that runs the example script with each Pull Request or push to main.

It converts the example script to a py file first and then runs it from the terminal with ipython.

Normally I would use regular python but in this case ipython is needed as there are some magic commands in the notebook.

I think this will help ensure the code works for future changes

you can see this action working over here https://github.com/shimwell/NeSST/pull/2

shimwell commented 10 months ago

@aidancrilly wondering if you have time to take a peak at this PR, many thanks

aidancrilly commented 10 months ago

@shimwell

Apologies, I am on pat leave so haven't been checking in. Thanks for this PR, all looks good, and a solid first test.

I am back to work in earnest from 17th Jan so hopefully can be quicker on updates and PRs from that point!

I am adding a couple of issues that I have thought of on leave, some of which might be of interest