Tests, tests, and more tests

aidantwoods / SecureHeaders

A PHP library aiming to make the use of browser security features more accessible.

MIT License

421 stars 23 forks source link

Tests, tests, and more tests #45

Closed aidantwoods closed 7 years ago

aidantwoods commented 7 years ago

Closes #39

I've wrapped in a couple bugfixes I patched while writing the tests 😉

Implicitly: Closes #3 Closes #27

aidantwoods commented 7 years ago

TODO: Complete testing of src/Operations (I'm not super concerned about these since there are some dedicated tests of the SecureHeaders main class that should require that all the operations are working to pass – I'll still get the individual tests added though)

franzliedke commented 7 years ago

Very nice job!

What's with the uppercase variables, though? ;)

aidantwoods commented 7 years ago

What's with the uppercase variables, though? ;)

Ah. Not terribly important/necessary, I tend to prefer using pascal case for objects and collections of objects atm ;) Only bothered adjusting as I was poking around in that file anyway.

aidantwoods commented 7 years ago

Happy to accept tests via PRs, I think that's me finished for now though!

2.0 here we come! 🎉