search

aidantwoods / SecureHeaders

A PHP library aiming to make the use of browser security features more accessible.
MIT License
421 stars 23 forks source link

Make the type checker more strict #67

Closed aidantwoods closed 6 years ago

aidantwoods commented 6 years ago

In hindsight allowing null by default probably isn't a good idea, so extend the syntax to support nullables, and make changes so that where nullables are needed information is explicitly conveyed to the type checker.

I don't think this should have any BC breaks (since the type checker isn't part of the public API), and nullables in the public API are documented where they are intentional.

aidantwoods commented 6 years ago

The fact that (sans doc related) tests didn't fail in e3fffe3 means that some of the public API still needs coverage.

aidantwoods commented 6 years ago

Changing milestone to a patch release since better checking for the documented types is a bugfix

franzliedke commented 6 years ago

I like the idea, sounds sensible. :+1: