don't ignore README.md on .gitattributes

aidantwoods / SecureHeaders

A PHP library aiming to make the use of browser security features more accessible.

MIT License

423 stars 23 forks source link

don't ignore README.md on .gitattributes #74

Closed cebe closed 5 years ago

cebe commented 5 years ago

while it is okay to ignore the docs folder with all the detailed information, I think a README file is a bit too essential to exclude.

see https://github.com/aidantwoods/SecureHeaders/commit/7c64bd4fe4c3a4a3cfbf3cae712489f2cce5de8d#r32537766

aidantwoods commented 5 years ago

Seems sensible :)

Tests are failing, but that's not to do with the change (obviously :) ). I think this error isn't reconcilable with PHP: https://travis-ci.org/aidantwoods/SecureHeaders/jobs/500603956#L509 using & in a by reference arg will cause an error (unfortunately) in PHP, but HHVM requires it. Guess I'll have to remove HHVM from the tests.