Add PHP >=8.1 compatibility

SOHELAHMED7 commented 12 months ago

This pull request does the following:

fix bugs in library and unit tests (described in PR comments and in https://github.com/aidantwoods/SecureHeaders/pull/75#issuecomment-1816565683)
make this library compatible with PHP >= 8.1 (also due to newer PHPUnit, this library will require PHP >= 8.1)
upgrade PHPUnit and other dependencies
upgrades tests to run with newer PHPUnit
upgrades PHP CS Fixer
setup GitHub actions to run PHPUnit and PHP CS Fixer

This pull request is endorsed by ☁️ cebe.cloud

SOHELAHMED7 commented 11 months ago

I have added comments in PR to identify the bugs. I am giving description here for bug:

Class Aidantwoods\SecureHeaders\SecureHeaders:: longDirective() was checking its argument against only string. However it can be null. Because this argument is carry forwarded from the method from which longDirective() is called and there it defaults to null
Similar is the case for Aidantwoods\SecureHeaders\SecureHeaders:: longSource()
Aidantwoods\SecureHeaders\SecureHeaders:: pipeline() was constructing Aidantwoods\SecureHeaders\Operations\RemoveCookies in wrong way (L1631). It is corrected.

franzliedke commented 11 months ago

I would strongly suggest to split up the unrelated parts of this PR: compatibility changes, CI changes, and especially bug fixes.

This drastically increases the chances of getting at least parts merged.

aidantwoods / SecureHeaders