search

aidenlab / Juicebox

Visualization and analysis software for Hi-C data -
https://aidenlab.org/juicebox
MIT License
241 stars 58 forks source link

Programmatically check for mapq 30 #213

Open nchernia opened 8 years ago

nchernia commented 8 years ago

for Arrowhead/HiCCUPs

sa501428 commented 8 years ago

Removing this issue i.e. will not fix. If someone really wants to run hiccups on mapq > 0, they should technically have the option to. Also, the only way we can check this via the filename, but that's too easy to change. Unless there's a programmatic check I'm not aware of, this does not appear to be something we should implement.

nchernia commented 8 years ago

We can check programmatically if the graphs file was there (true for our maps)

On Tue, May 24, 2016 at 10:54 PM, Muhammad Saad Shamim < notifications@github.com> wrote:

Closed #213 https://github.com/theaidenlab/JuiceboxDev/issues/213.

— You are receiving this because you were assigned. Reply to this email directly or view it on GitHub https://github.com/theaidenlab/JuiceboxDev/issues/213#event-671206902

Neva Cherniavsky Durand, Ph.D. Staff Scientist, Aiden Lab www.aidenlab.org

sa501428 commented 6 years ago

Not sure what I was thinking when I wrote my comments above in 2016 smh - I was wrong. We definitely need to have a check for this. I've lost count of the times I've accidentally run hiccups on mapq0 instead of map30 when doing custom hiccups runs...