search

aidenlab / Juicebox

Visualization and analysis software for Hi-C data -
https://aidenlab.org/juicebox
MIT License
245 stars 58 forks source link

zooming in isn't centered #237

Closed nchernia closed 8 years ago

nchernia commented 8 years ago

It's super annoying

(i.e. if I load a map and then slide resolution slider, jumps to random place, not centered on diagonal)

sa501428 commented 8 years ago

I've been working on this for a while. Issue is a bit more complicated, since the code is built so it centers properly at high resolutions; however, low resolutions/window sizing cause various issues to offset the centering.

nchernia commented 8 years ago

When I load a map and then zoom in to high res, it's still not centered.

On Wed, Dec 9, 2015 at 2:12 PM, Muhammad Saad Shamim < notifications@github.com> wrote:

I've been working on this for a while. Issue is a bit more complicated, since the code is built so it centers properly at high resolutions; however, low resolutions/window sizing cause various issues to offset the centering.

— Reply to this email directly or view it on GitHub https://github.com/theaidenlab/Juicebox/issues/237#issuecomment-163360819 .

Neva Cherniavsky Durand, Ph.D. Staff Scientist, Aiden Lab www.aidenlab.org

sa501428 commented 8 years ago

That's because of the window size. Choose a region at 100kb, then zoom in. It should be centered based on the 100 kb resolution. Unfortunately, zooming out from 100kb throws off bounds, hence it appears uncentered. Will tackle this soon.

nchernia commented 8 years ago

Yes but it's still the case that 1) loading a map 2) changing the resolution slider

shouldn't zoom you in to somewhere totally random; it should at the very least be on the diagonal if not in the center of the chromosome.

On Wed, Dec 9, 2015 at 2:36 PM, Muhammad Saad Shamim < notifications@github.com> wrote:

That's because of the window size. Choose a region at 100kb, then zoom in. It should be centered based on the 100 kb resolution. Unfortunately, zooming out from 100kb throws off bounds, hence it appears uncentered. Will tackle this soon.

— Reply to this email directly or view it on GitHub https://github.com/theaidenlab/Juicebox/issues/237#issuecomment-163367362 .

Neva Cherniavsky Durand, Ph.D. Staff Scientist, Aiden Lab www.aidenlab.org

sa501428 commented 8 years ago

Right, I know. But it's not random (at least not anymore - there was a previous bug where it was actually random due to mismatch of bp vs px). Will look into this soon.