aidenlab / juicer

A One-Click System for Analyzing Loop-Resolution Hi-C Experiments
http://aidenlab.org
MIT License
410 stars 181 forks source link

juicer_tools.jar dump creates a dense matrix bigger than the requested limits #212

Closed jazberna1 closed 2 years ago

jazberna1 commented 3 years ago

Are you sure this is a bug? I believe this is a bug, already mentioned here: https://github.com/aidenlab/juicer/issues/132

Describe the bug The juicer juicer_tools.jar dump command seems to create a matrix bigger than the requested limits when used with the -d (dense) flag.

To Reproduce run the example provided in https://github.com/aidenlab/juicer/wiki/Data-Extraction adding the -d flag:

java -jar juicer_tools.jar dump observed KR https://hicfiles.s3.amazonaws.com/hiseq/gm12878/in-situ/combined.hic 1:20480000:40960000 1:20480000:40960000 BP 10000 combined_10Kb.txt -d

Then plotting the resulting matrix combined_10Kb.txt gives the attached jpg where there is a portion of the image surrounding the requested limits.

Expected behavior I expected to get an image restricted to 1:20480000:40960000

Screenshots combined_10Kb

Desktop (please complete the following information):

Additional context Many thanks! Jorge

sa501428 commented 2 years ago

I would highly recommend using https://github.com/aidenlab/straw instead of the dump command.