search

aidenlab / straw

Extract data quickly from Juicebox via straw
MIT License
62 stars 36 forks source link

More fixes for Windows #71

Closed cwenger closed 3 years ago

sa501428 commented 3 years ago

Hey @cwenger! Could you actually implement the shorts/ints/longs with stdint.h as in @nchernia's suggestion? https://github.com/aidenlab/straw/pull/69#pullrequestreview-670540582 Also for reference: https://github.com/aidenlab/straw/pull/69#issuecomment-850593502

cwenger commented 3 years ago

@sa501428 Sure I'll give it a try!

cwenger commented 3 years ago

Ok @sa501428 see what you think. I wasn't sure if I should use the fixed size integers everywhere or only for data read from .hic files and I ended up somewhere in between.

cwenger commented 3 years ago

@sa501428 Just seeing if you've had an opportunity to take a look at these changes yet. Thanks!