search

aidenlab / straw

Extract data quickly from Juicebox via straw
MIT License
62 stars 36 forks source link

Declare curl in SystemRequirements in the R package #80

Closed Enchufa2 closed 3 years ago

Enchufa2 commented 3 years ago

Since curl.h is required, it should be declared in SystemRequirements.

sa501428 commented 3 years ago

@cwenger would you be able to handle this?

cwenger commented 3 years ago

@Enchufa2 Can you elaborate on this, or do a pull request? I don't have a full understanding of how the build works, especially on Windows where I used the configuration from https://github.com/jeroen/curl. They have: SystemRequirements: libcurl: libcurl-devel (rpm) or libcurl4-openssl-dev (deb). so I can add that if it's helpful.

Enchufa2 commented 3 years ago

Per the Writing R Extensions manual,

Dependencies external to the R system should be listed in the ‘SystemRequirements’ field

Adding Jeroen's line would do.

cwenger commented 3 years ago

Done. Thanks for the suggestion.