aidenlx / alx-folder-note

Add description, summary, and more info to folders with folder notes.
MIT License
244 stars 13 forks source link

fix: compatible with Obsidian 1.2.0 version #103

Closed bytemain closed 1 year ago

bytemain commented 1 year ago

this close: #102

related:


@aidenlx currently I cannot run this repo success. it seem you have some private package inside package.json such as:

and the dep is broken:

CleanShot 2023-03-31 at 14 04 03@2x

I delete the yarn.lock and it resolved, so I don't know if I should submit yarn.lock.

Mara-Li commented 1 year ago

Hello! Little question : How do you build the main.js ? I have error on my side...

bytemain commented 1 year ago

Hello! Little question : How do you build the main.js ? I have error on my side...

  1. Remove these deps: @aidenlx/ts-config @aidenlx/prettier-config

replace tsconfig to:

{
  "compilerOptions": {
    "moduleResolution": "node",
    "target": "es6"
  },
  "include": ["src/**/*.ts"]
}
  1. Delete the yarn.lock
bytemain commented 1 year ago

build.zip

For whom cannot build but want folder-note worked.

The code is not minified so you can check it to ensure it is safe.

Mara-Li commented 1 year ago

Work like a charm! Thank you :)

namtrah commented 1 year ago

This works for me as well. Thanks

aidenlx commented 1 year ago

many thanks! I haven't upgrade to 1.2.0 yet, sorry for the long wait. Will see if I have time to review the PR this weekend

7596ff commented 1 year ago

thanks for the fix and the build.zip, i could not seem to build your branch from source.

bytemain commented 1 year ago

thanks for the fix and the build.zip, i could not seem to build your branch from source.

The original code already had dependency issues. You can check the details in this PR's content to solve the problem.