aidenlx / alx-folder-note

Add description, summary, and more info to folders with folder notes.
MIT License
244 stars 13 forks source link

[FR/BUG] Deleting a folder note/folder should NEVER delete anything else! #106

Open SPiCaRiA opened 1 year ago

SPiCaRiA commented 1 year ago

Hi, for deleting folder notes, currently there are two commands available:

  1. Delete linked folder
  2. Delete note and linked folder

Actually, for people who use strategy of "inside folder same name", I don't see any difference between these two commands. That is to say, the folder, the folder note, and whatever is inside the folder, are all deleted. The second command deletes the folder note that is outside of the folder as well.

First, I think everything other than the folder and the folder note shall never be deleted, as they are out of the scope of what this plug-in intends to manage.

Second, I think we should make the behavior clear and consistent regardless of the strategy:

So the actual logic would be:

TBH, I don't think my solution is flawless. There are some foreseeable problems, e.g., naming collision between files in the parent folder and the files in the folder note folder. But yeah, let me know how people think about this.