search

aidenlx / alx-folder-note

Add description, summary, and more info to folders with folder notes.
MIT License
244 stars 13 forks source link

#134 - fix to breaking changes introduced in Obsidian 1.5.4 (they did an internal refactoring of File Explorer, the fix follows the refactoring accordingly) #138

Open SebastianMC opened 5 months ago

SebastianMC commented 5 months ago

I'm the author of the obsidian-custom-sort plugin which was also affected by the breaking changes in File Explorer introduced in Obsidian 1.5.4

I did a reverse engineering of Obsidian code to track back the relevant changes and then applied the fixes onto my plugin.

The fixes are simple and isolated, in this pull request I'm showing how to apply them onto the alx-folder-note plugin (which I love and use every day).

FynnFreyer commented 5 months ago

This seems to take care of #130 as well (therefore making #133 superfluous).

Also, I'm using this in my vault and can confirm it works flawlessly. Thanks for the good work!

SebastianMC commented 4 months ago

Hi @pho3nixf1re

I'm unclear on the processes and rules around PR's and merging them in this github project. While I've created this pull request, at the same time I don't have the write access required to do a merge. Who can do the actual merge (or additional review, if the process requires that)?

huyz commented 4 months ago

@SebastianMC I'm using your fork directly until this is merged in. Thanks